Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-enable installonlypkgs on tdnf for Azure Linux 3.0 #10700

Merged
merged 3 commits into from
Oct 23, 2024

Conversation

sameluch
Copy link
Contributor

Merge Checklist

All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)

  • The toolchain has been rebuilt successfully (or no changes were made to it)
  • The toolchain/worker package manifests are up-to-date
  • Any updated packages successfully build (or no packages were changed)
  • Packages depending on static components modified in this PR (Golang, *-static subpackages, etc.) have had their Release tag incremented.
  • Package tests (%check section) have been verified with RUN_CHECK=y for existing SPEC files, or added to new SPEC files
  • All package sources are available
  • cgmanifest files are up-to-date and sorted (./cgmanifest.json, ./toolkit/scripts/toolchain/cgmanifest.json, .github/workflows/cgmanifest.json)
  • LICENSE-MAP files are up-to-date (./LICENSES-AND-NOTICES/SPECS/data/licenses.json, ./LICENSES-AND-NOTICES/SPECS/LICENSES-MAP.md, ./LICENSES-AND-NOTICES/SPECS/LICENSE-EXCEPTIONS.PHOTON)
  • All source files have up-to-date hashes in the *.signatures.json files
  • sudo make go-tidy-all and sudo make go-test-coverage pass
  • Documentation has been updated to match any changes to the build system
  • Ready to merge

Summary

What does the PR accomplish, why was it needed?
Added installonlypkgs configuration missed following the port for Mariner 2.0. Added the configuration entry via a patch and updated the package list for Azure Linux 3.0.

Change Log
  • add patch for installonlypkgs by default for Azure Linux 3.0
Does this affect the toolchain?

YES

Test Methodology

@sameluch sameluch requested a review from a team as a code owner October 11, 2024 18:51
@sameluch sameluch requested a review from rlmenge October 11, 2024 18:51
@sameluch sameluch changed the title Sammeluch/tdnf install limit Re-enable installonlypkgs on tdnf for Azure Linux 3.0 Oct 11, 2024
Copy link
Contributor

@eric-desrochers eric-desrochers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. It will force tdnf to respect the installonly limit allowing to keep 3 version of a kernel as it should and as dnf does.

Copy link
Contributor

@rlmenge rlmenge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add kernel-uki, a new kernel we added for 3.0 which I missed in my initial review

@sameluch
Copy link
Contributor Author

Please add kernel-uki, a new kernel we added for 3.0 which I missed in my initial review

@rlmenge Added kernel-uki to the patch, reran buddy build for good measure: https://dev.azure.com/mariner-org/mariner/_build/results?buildId=662570&view=results
re-review when you have a moment

@sameluch sameluch merged commit 8dd677a into 3.0-dev Oct 23, 2024
12 checks passed
@sameluch sameluch deleted the sammeluch/tdnf-install-limit branch October 23, 2024 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants